I don’t have a ton of evidence. But yes.
1 Like
Just to let you know I found that if I leave the console open too long it goes into a stutter as well. Very odd. Closing it resolves it but definitely something someone should be aware of.
Thanks again gibs, I’m using Edge and I didn’t quite find line parity but I just searched down what you were up to and replaced all of the comment M6’s and commentMatcher’s. I’ll give this a test in a bit. Glad that these are pretty straight forward shifts and hopefully they will implement them in their next update.
Made an issue, and pull request as per your guidance. We will see what feedback I get and if there are unit tests to be added somewhere.
1 Like
I thought about it some more and a better approach would be to just insert data = data.replace(/\([^\)]*\)/gm, ''); between line 250 and 251 of GrblController.js. By doing it this way, you can still pass variables to the terminal when using macros with inline comments. This will also stop the SO5 from locking up if you were to manually type a inline comment into the console. No other changes are needed with this method. I have tested it on my SO5 and everything seems to be functioning as intended.
Example change done in index.js line 8898 found in C:\Program Files\gSender\resources\app\server for v1.2.2
You could also just replace return data; with return data.replace(/\([^\)]*\)/gm, ''); instead of inserting a new line.
2 Likes
I felt like there would be single point of egress to the controller, but I am not familiar enough with the code base or how you do serial I/O in javascript to have found it. This looks like what I was looking for.
FYI to all - I forked the gSender repository and added in the discussed change. I also added the SO5’s product ID to the recognized device list. It will now show up as recognized when connecting.
You can find a patched build of v1.2.2 for windows here:
4 Likes
Thanks Tanner. Appreciate the time and work you have put into this.
I’ll retract my PR for gsender. Please add your own so that they might adopt the changes in mainline.
Why do you desire to use Gsender? I tried it an had nothing but issues. It appears its not fully ready for prime time. Rxman
Seems fine from what I can tell. The issues were not with GSender but instead the 5pro that I was connecting it to.
Some things it does that CM doesn’t:
- Multiple zeros through a feature called workspaces. (I can simulate this with user macros in CM though)
- Pendent mode (link to it via your phone)
- It has a surfacing tool that generates raster surfacing jobs.
- Macro support appears to be more than just snippets of gcode…like there is some amount of scriptabilty
I don’t, however, like how small and close together the jogging controls on the screen are in gsender.
What version did you try? In case you haven’t noticed, even CM has gone through plenty of changes.
Oh, One more thing that I didn’t love, gsender didn’t appear to save zeros between opens.
I’m not following you on not saving zeros. It’s always saved my last one just as CM does. Plus it has the option to save multiple zeros.
If you shutdown CM and open it back up, or perhaps return to a project a day later after shutting everything down, CM knows where your previous zero was.
It didn’t appear to me like this was the case with gsender, but then again I was also dealing with the machine freezing as per the gcode comment issue. That certainly muddied the waters.
Gerald, perhaps wait until you get all of your gCode problems settled.
GSender works without any of the problems mentioned here for many of us. Its a mature product.
1 Like
It’s the machine (GRBL) that saves the G54 fixture offset (Your zero location). It works with Gsender too.
3 Likes
Motion saves your offsets in Motion, and it can also clear those offsets from the controller with a G10L2X0Y0Z0 and reload them from the memory on your computer.(At least this is what Motion used to do.)
Switching back and forth from Motion and any other sender can cause loss of offsets.
FYI to anyone interested, thanks to @Gibs efforts, the 1.41 version of GSender should not send the inline comments and better work with the S5.
2 Likes
Giving it a whirl this afternoon. Appreciate everyone coming together to troubleshoot and showcase their strengths. Thought I was an edge case and finding it both effected more of us and finding a patch, and contributing a solve, AND for it to get rolled in. Hells yea. Owe ya’ll a beer. 